Refactor produce_latex_macro #39184
Merged
Refactor produce_latex_macro #39184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit f3208ef; changes) is ready! 🎉 |
|
Much cleaner |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2024
Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
|
I think when you merge develop, the bot reverts the positive review so you have to re add it. I guess it's meant for cases when you actually change the PR, but merging develop should be ok. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
Alternative to sagemath#39181 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. (no behavior change) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39184 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 17, 2025
### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #39181 .
📝 Checklist
⌛ Dependencies